augusto
/
hack-assembler
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix possible stack overflow

This commit is contained in:
Augusto Gunsch 2020-10-25 09:53:54 -03:00
parent 189ad12481
commit d758eaff6a
No known key found for this signature in database
GPG Key ID: F7EEFE29825C72DC
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
assembler.c
View File

@ -4,7 +4,7 @@
#include <stdlib.h> #include <stdlib.h>
#include <ctype.h> #include <ctype.h>
#define RAM_LIMIT 24576 #define RAM_LIMIT 24577
#define TOP_VAR 16383 #define TOP_VAR 16383
#define BOT_VAR 16 #define BOT_VAR 16
#define ADD_STR_LEN 7 #define ADD_STR_LEN 7
@ -493,10 +493,10 @@ int main(int argc, char* argv[]) {
int labelscount = 0; int labelscount = 0;
int lnwidth = 0; int lnwidth = 0;
gatherinfo(input, &lnscount, &labelscount, &lnwidth); gatherinfo(input, &lnscount, &labelscount, &lnwidth);
struct line* lns[lnscount]; struct line** lns = (struct line**)malloc(sizeof(struct line*)*lnscount); // has to be on the heap; can be huge and cause a stack overflow
// line chopping // line chopping
struct symbol* labels[labelscount]; struct symbol** labels = (struct symbol**)malloc(sizeof(struct symbol*)*labelscount); // same for this one
labelscount = 0; labelscount = 0;
struct symbol* vars[TOP_VAR - BOT_VAR]; struct symbol* vars[TOP_VAR - BOT_VAR];
@ -510,6 +510,7 @@ int main(int argc, char* argv[]) {
stripvars(vars, &varscount, labels, &labelscount, lns, lnscount); stripvars(vars, &varscount, labels, &labelscount, lns, lnscount);
freesymbols(vars, varscount); freesymbols(vars, varscount);
freesymbols(labels, labelscount); freesymbols(labels, labelscount);
free(labels);
// actual translation // actual translation
char** bin = translate(lns, lnscount); char** bin = translate(lns, lnscount);
@ -517,6 +518,7 @@ int main(int argc, char* argv[]) {
free(lns[i]->ln); free(lns[i]->ln);
free(lns[i]); free(lns[i]);
} }
free(lns);
// file output // file output
char outf[fnamelen+2]; char outf[fnamelen+2];